Force explicit encoding/decoding of arguments and return values to calls to Erlang #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We go very explicit here and assume that all Luerl functions require their arugments to be explicitly encoded and return values decoded. This is still a test version.
Also commented out some test output.
So luerl_new has now become the luerl. For backwards compatibility save the old luerl unchanged as luerl_old. The documentation and test suites have updated as well. A major change in luerl is the encoding/decoding of functions which are assumed to use encoded arguments and return values.
These just call the erlang module functions moving the state to the first argument.
Fix tests on develop-encode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE that this branch is still experimental and probably needs working on.