Prevent build machine paths being used in published artifacts #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davydog187
force-pushed
the
fix-build-xrl
branch
from
8ce4df8
to
770d126
Compare
davydog187
commented
Sep 29, 2024
| Conf0 ++ [{erl_opts,Copts}] | ||
| end, | ||
|
|
||
| %% Prevent build directories being used in output files | ||
|
|
||
| XrlYrlOpts = if Version > "24" -> |
|
@davydog187 I think something is going wrong here because something is not working with the changes you have made to |
|
I cannot see these options in the compiler documentation or in the source code of the compiler, or anything else for that matter. Where did you see it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, wherever
luerlis built before publishing will include the user's local filesystem paths. You can see @rvirding path's in hexpm https://preview.hex.pm/preview/luerl/1.2.2/show/src/luerl_scan.erlThis fixes the compiler to always use just the basename to prevent this leakage.