Added public methods to iterate all blocks of a local function + Floating point check #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuvenpo
force-pushed
the
iter-func-builder-arena
branch
from
fbe7bf9
to
7eb38d9
Compare
reuvenpo
force-pushed
the
iter-func-builder-arena
branch
from
7eb38d9
to
ff51789
Compare
|
seems like the CI is failing due to issues that are unrelated to my additions |
reuvenpo
changed the title
reuvenpo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two methods to iterate over all the blocks in a LocalFunction. This allows making per-block transformations, or simple full-function analysis, without having to manually navigate the function's execution branches to find all reachable blocks. CC #234
2022-08-10 update: I added a floating point check to modules. I believe it is exhaustive but I'd love to get a review :)