style: simplify string formatting for readability #4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamirmahal
commented
Nov 20, 2024
|
It sounds like you're using an automated tool to find these? From a quick look I found at least the similar tembo-io/pgmq#341, stalwartlabs/mail-server#909, mullvad/pfctl-rs#119 and amodm/webbrowser-rs#91. It would be really nice if more context was given (that these were found in an automated fashion, if so), otherwise it feels disingenuous? |
|
Oh, I found these with |
|
Ah, makes sense. Would you be up for adding the specific lints to |
|
Sure! I'll take a look at that right now. |
hamirmahal
force-pushed
the
style/simplify-string-formatting-for-readability
branch
from
0bc07b8
to
ed03405
Compare
madsmtm
reviewed
Nov 22, 2024
hamirmahal
force-pushed
the
style/simplify-string-formatting-for-readability
branch
from
ed03405
to
1ef558f
Compare
hamirmahal
force-pushed
the
style/simplify-string-formatting-for-readability
branch
from
1ef558f
to
f72f9a2
Compare
hamirmahal
deleted the
style/simplify-string-formatting-for-readability
branch
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4000
changelogmodule if knowledge of this change could be valuable to users