Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note the platform versions that winit supports #2416

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Aug 10, 2022

Currently only macOS and Windows, since I somewhat know how versioning works there. Missing iOS and Android! Would it make sense to do a similar thing for Wayland and X11?

I think we should do something similar for WASM, but unsure how, maybe it should be as verbose as specifying each browser an the version that it is expected to work on?

Spawned by #2409 (comment).

@madsmtm madsmtm added S - docs Awareness, docs, examples, etc. C - needs discussion Direction must be ironed out labels Aug 10, 2022
@maroider
Copy link
Member

maybe it should be as verbose as specifying each browser an the version that it is expected to work on?

I think it could make sense to list what browsers we specifically try to support, and since browsers need to be updated on a regular basis, I think it's not that unreasonable to only really try to target the latest stable version (and maybe one or two older versions if there's a desire and bandwidth for it) of each. In practice, I suspect this ends up being mainly Chrome and Firefox, and maybe Safari, but I'm unsure if anyone who touches the web backend with any regularity actually tests anything on Safari.

@madsmtm
Copy link
Member Author

madsmtm commented Aug 10, 2022

Well, also kinda depends on what these support tables are to be used for - reconsidering, I think it makes sense to guarantee support for some specific version (or a general "latest firefox + chrome"), which also means that if a PR doesn't support that version, it's a breaking change.

Of course, if someone reports that winit doesn't work on some lower version, we'll do our best to fix that.

@kchibisov kchibisov merged commit 6f60c7a into master Jan 15, 2023
@kchibisov
Copy link
Member

That should be fine as is for now.

@madsmtm madsmtm deleted the supported-versions branch January 15, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - needs discussion Direction must be ironed out S - docs Awareness, docs, examples, etc.
Development

Successfully merging this pull request may close these issues.

3 participants