Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #71

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Update dependencies #71

merged 1 commit into from
Feb 21, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Feb 20, 2023

Using the latest winit version in examples fixes resizing behavior on Wayland, so the workaround for that in the winit example is also removed here.

@ids1024 ids1024 requested a review from john01dav as a code owner February 20, 2023 18:06
@ids1024
Copy link
Member Author

ids1024 commented Feb 20, 2023

error: package jpeg-decoder v0.3.0 cannot be built because it requires rustc 1.61.0 or newer, while the currently active rustc version is 1.60.0

Hm. I guess image can be left on the previous version.

@ids1024
Update windows-sys dependency, and winit dev dependency
dce6cbc 
Using the latest `winit` version in examples fixes resizing behavior on
Wayland, so the workaround for that in the `winit` example is also
removed here.
@notgull
Copy link
Member

notgull commented Feb 20, 2023

I feel like we can bump to 1.61.

@ids1024
Copy link
Member Author

ids1024 commented Feb 20, 2023

Probably, though it also doesn't matter for a dev-depedency where the new version probably doesn't make any difference to the examples using it.

It seems good to keep softbuffer in sync with winit's Rust MSRV. I guess both can be updated when there's some more significant reason to do so.

@notgull
Copy link
Member

notgull commented Feb 20, 2023

winit will probably bump its MSRV to 1.61 soon anyways (rust-windowing/winit#2614 and rust-windowing/winit#2679), so I think a one-version bump wouldn't be that bad.

@jackpot51 jackpot51 merged commit 83c0f92 into master Feb 21, 2023
@jackpot51 jackpot51 deleted the dependencies branch February 21, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes

@john01dav john01dav Awaiting requested review from john01dav

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ids1024 @notgull @jackpot51