Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egl/display: workaround gbm platforms on EGL 1.4 #1716

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

kchibisov
Copy link
Member

Some EGL drivers report the KHR extension with EGL 1.4, which doesn't make any sense, however given that the constant for MESA and KHR is the same, we can check for KHR in MESA branch, but still use the Ext functions.

Fixes #1708.

Some EGL drivers report the KHR extension with EGL 1.4, which doesn't
make any sense, however given that the constant for MESA and KHR is the
same, we can check for KHR in MESA branch, but still use the Ext
functions.

Fixes #1708.
CHANGELOG.md Outdated Show resolved Hide resolved
glutin/src/api/egl/display.rs Outdated Show resolved Hide resolved
glutin/src/api/egl/display.rs Outdated Show resolved Hide resolved
kchibisov and others added 2 commits November 12, 2024 19:05
Co-authored-by: Marijn Suijten <[email protected]>
Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like workarounds for drivers, but I guess that's why we have Vulkan nowadays :)

Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks great, thanks for driving this!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Marijn Suijten <[email protected]>
@kchibisov kchibisov merged commit e8962ee into master Nov 12, 2024
43 checks passed
@kchibisov kchibisov deleted the workaround-broken-gbm branch November 12, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

EGL_KHR_platform_gbm (but not EGL_MESA_platform_gbm) client extension present on EGL 1.4
2 participants