Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh-CN translation to intro #293

Merged
merged 5 commits into from
Jan 17, 2022
Merged

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Jan 16, 2022

Fix #292

I added it to intro rather than readme because it's the first page seen in the website, having it in the first place will make it more discoverable.

@pickfire pickfire changed the title Add zh translation to intro Add zh-CN translation to intro Jan 16, 2022
@simonsan
Copy link
Collaborator

simonsan commented Jan 16, 2022

I would probably rather do it this way, still not sure though.

  • Create a translations.md and add it to SUMMARY.md as a subcategory under Introduction.
  • Then link to the translation from there

./SUMMARY.md

- [Introduction](./intro.md)
  - [Translations](./translations.md)

./translations.md

# Translations

- [简体中文翻译](https://fomalhauthmj.github.io/patterns/)

If you want to add a translation, please open an issue in the [main repository](https://github.com/rust-unofficial/patterns).

@Fomalhauthmj
Copy link

@pickfire, I think @simonsan's approach is better, can you push a new commit?

@pickfire
Copy link
Contributor Author

pickfire commented Jan 17, 2022

@simonsan Thanks, I have updated it as what you said. I didn't know summary is the main entry file.

Fomalhauthmj
Fomalhauthmj previously approved these changes Jan 17, 2022
@simonsan simonsan merged commit 2577a11 into rust-unofficial:main Jan 17, 2022
@pickfire pickfire deleted the patch-1 branch January 18, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation: Newer simplified Chinese
3 participants