init multiboot2-common and use same safe memory abstractions also in multiboot2-header crate #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
mb-hdr
branch
7 times, most recently
from
00624c8 to
2cdbe5f
Compare
Although the commit history doesn't reflect it, this is the outcome after drying dozens of designs in much more time than I'd like to admit :D However, although this is complex, it solves real problems and is a true value-add. Also, it reflects so many findings and learnings.
This especially significantly changes the builder. The normal public API however is only slightly affected.
This especially significantly changes the builder. The normal public API however is only slightly affected.
Now, the last `#[cfg_attr(miri, ignore)]` is gone!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inits a new
multiboot2-commoncrate and workspace member. The ideas of the improvements in #226 have been generalized and can now also improve the situation in themultiboot2-headercrate.Now, (for real!) all unit tests pass Miri. I misleadingly made this claim already in #226 but I forgot a few
#[cfg_attr(miri, ignore)]statements - sorry.Further, lots of UB and memory issues have been resolved in the framebuffer tag and the elf section tag. This is a significant refactoring of the internals, and it guarantees memory safety now. Big success :)
A lot of UB resulted in old code from the early days.
This closes #160 and closes #145.