Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some test support for BSDs #195

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Jan 11, 2021

Part of #78

This PR attempts to use https://github.com/vmactions/freebsd-vm to run tests in CI on a FreeBSD target. It appears to use VirtualBox virtualization on a MacOS host.

If I manage to get things working on this target then I'll try NetBSD and Solaris as well.

@KodrAus
Copy link
Contributor Author

KodrAus commented Jan 11, 2021

Looks like we've got some tests running in FreeBSD along with a failure: https://github.com/rust-lang/socket2/runs/1679158951?check_suite_focus=true#step:3:1567

failures:

---- only_v6 stdout ----
thread 'main' panicked at 'assertion failed: `(left != right)`
  left: `true`,
 right: `true`: initial value and argument are the same', tests/socket.rs:772:1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@Thomasdezeeuw
Copy link
Collaborator

@KodrAus fixed the test issue in #196.

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things, but LGTM otherwise. Can you rebase this on master to check if I fixed the ipv6_only test failure with #196.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@KodrAus
Copy link
Contributor Author

KodrAus commented Jan 11, 2021

Done! Let's see if it passes now.

You may also be interested in vmactions/freebsd-vm#8, which explains why the FreeBSD output contains a lot of garbled text right now before it gets to our code.

@KodrAus
Copy link
Contributor Author

KodrAus commented Jan 11, 2021

Looks like we're green now.

If you like I should be able to follow this one up with NetBSD and Solaris too.

@Thomasdezeeuw Thomasdezeeuw merged commit 6137664 into rust-lang:master Jan 11, 2021
@Thomasdezeeuw
Copy link
Collaborator

@KodrAus thanks. Adding NetBSD and Solaris would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants