Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo #134987

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Update cargo #134987

merged 1 commit into from
Jan 1, 2025

Conversation

weihanglo
Copy link
Member

5 commits in c86f4b3a1b153218e6e50861214b0b4b4e695f23..d73d2caf9e41a39daf2a8d6ce60ec80bf354d2a7
2024-12-24 17:49:48 +0000 to 2024-12-31 20:51:21 +0000

r? ghost

@weihanglo weihanglo self-assigned this Dec 31, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2024

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

cc #134720 #122565

@bors
Copy link
Contributor

bors commented Dec 31, 2024

📌 Commit acb38ec has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2024
@bors
Copy link
Contributor

bors commented Dec 31, 2024

⌛ Testing commit acb38ec with merge 4e59b1d...

@bors
Copy link
Contributor

bors commented Jan 1, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 4e59b1d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2025
@bors bors merged commit 4e59b1d into rust-lang:master Jan 1, 2025
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Jan 1, 2025
@weihanglo weihanglo deleted the update-cargo branch January 1, 2025 01:36
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4e59b1d): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
-0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-0.6%, -0.6%] 1

Max RSS (memory usage)

Results (primary 1.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Cycles

Results (primary 3.5%, secondary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-3.0%, -2.0%] 2
All ❌✅ (primary) 3.5% [3.5%, 3.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.425s -> 761.038s (-0.18%)
Artifact size: 325.57 MiB -> 325.55 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants