Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mimalloc in rustc #132796

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use mimalloc in rustc #132796

wants to merge 1 commit into from
+49 −28

Conversation

iSwapna
Copy link
Contributor

@iSwapna iSwapna commented Nov 9, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2024
@iSwapna iSwapna changed the title Ume mimalloc in rustc Use mimalloc in rustc Nov 9, 2024
@fee1-dead
Copy link
Member

We've had several experiments in #92249 and #92317. Any reasons for how the performance of mimalloc could have changed to justify replacing jemalloc with it?

@iSwapna
Copy link
Contributor Author

iSwapna commented Nov 9, 2024 •
edited
Loading

We've had several experiments in #92249 and #92317. Any reasons for how the performance of mimalloc could have changed to justify replacing jemalloc with it?

My goal is to measure the performance and see if it's worth to do anything further. That's why the PR is a draft. I needed the CI to run. Let me know if that is something I can do.

@fee1-dead
Copy link
Member

There are some version updates, and it doesn't hurt to try. But please follow some additional things I have done in #92249 too, namely replacing it for rustdoc too. Because we also benchmark rustdoc in the perf suite it is helpful to see the impact there also.

afterwards I think it is okay to request a perf run.

@iSwapna
Copy link
Contributor Author

iSwapna commented Nov 9, 2024

There are some version updates, and it doesn't hurt to try. But please follow some additional things I have done in #92249 too, namely replacing it for rustdoc too. Because we also benchmark rustdoc in the perf suite it is helpful to see the impact there also.

afterwards I think it is okay to request a perf run.

I will do that! Thank you for the pointers.

@klensy
Copy link
Contributor

klensy commented Nov 9, 2024

There was more recent #103944 and #122369

@iSwapna
Copy link
Contributor Author

iSwapna commented Nov 9, 2024

There was more recent #103944 and #122369

Will run the perf and then compare with last run

@clubby789 clubby789 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2024
@iSwapna
Copy link
Contributor Author

iSwapna commented Nov 22, 2024 •
edited
Loading

@fee1-dead I will get back to this after exams (late Dec).

@bors
Copy link
Contributor

bors commented Dec 3, 2024

☔ The latest upstream changes (presumably #133770) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iSwapna @rustbot @fee1-dead @klensy @bors @pnkfelix @clubby789