-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint for broken doc links #13696
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
8d859c9
to
6ff53c7
Compare
Just noticed there are tests failing due to a false positive like this:
This will be considered a broken link although actually it isn't. I guess in order to fix it I won't be able to check |
I will try to use similar approach used on https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/tabs_in_doc_comments.rs |
fc34f5d
to
640f282
Compare
640f282
to
8deb383
Compare
☔ The latest upstream changes (presumably 8298da7) made this pull request unmergeable. Please resolve the merge conflicts. |
fixes #2179
changelog: [
doc_broken_link
]: Add pedantic lint to catch broken doc links that won't produce a link tag by rustdoc.