Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually set library paths in .github/driver.sh #12812

Merged
merged 1 commit into from
May 16, 2024

Conversation

Alexendoo
Copy link
Member

Fixes https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Windows.20CI.20failing

Rustup 1.27.1 no longer adds [SYSROOT]/bin to PATH by default - rust-lang/rustup#3825. This is fine for the packaged binaries since windows loads dlls from the folder the executable is in, but our built one is in a different folder

There's an environment variable to get the old behaviour back, but as it's deprecated and not much code I think returning to setting it manually is fine

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2024

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 16, 2024
@flip1995
Copy link
Member

@bors r+

Thanks, I wanted to try to remove the rustup show active-toolchain command anyway.

@bors
Copy link
Contributor

bors commented May 16, 2024

📌 Commit 821dc87 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 16, 2024

⌛ Testing commit 821dc87 with merge 6c8ff3f...

@bors
Copy link
Contributor

bors commented May 16, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 6c8ff3f to master...

@bors bors merged commit 6c8ff3f into rust-lang:master May 16, 2024
2 checks passed
@Alexendoo Alexendoo deleted the driver-integration branch May 16, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants