database: Add versions.yank_message column
#9274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustin170506
force-pushed
the
rustin-patch-yank-message
branch
from
1dd5c45
to
c9d832b
Compare
Rustin170506
commented
Aug 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9274 +/- ##
==========================================
- Coverage 89.29% 89.14% -0.15%
==========================================
Files 282 283 +1
Lines 28629 28823 +194
==========================================
+ Hits 25563 25693 +130
- Misses 3066 3130 +64 ☔ View full report in Codecov by Sentry. |
Turbo87
reviewed
Aug 18, 2024
Turbo87
added
C-enhancement ✨
Turbo87
changed the title
versions.yank_message column
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-yank-message
branch
from
d7d3eab
to
7083232
Compare
Rustin170506
commented
Aug 20, 2024
Turbo87
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9193
In this PR, I added a new column to the
versionstable.I picked the text here. For a simple text-based message, I think the length is enough.
I am not sure if we should consider using JSONB here to accommodate the possibility of needing to store more structured information in the future.
I also marked it private, I guess before we expose the new API to users, we should keep it private.