Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database: Add categories and keywords columns to the versions table #10078

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 26, 2024

Similar to #9998, this PR adds two new columns to the versions database table: categories and keywords

These columns are filled with the corresponding values from the Cargo.toml file when new crates/versions are published.

Compared to the per-crate categories and keywords, these are not saved in dedicated crates_categories and crates_keywords tables, but just as a regular Postgres array column. The reason for this is that we don't need to find versions by category or keyword. We only need the data to set the new crate categories/keywords when the "default version" of a crate changes (will be implemented in a follow-up PR, once the data is backfilled in the database).

Related:

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 26, 2024
@Turbo87 Turbo87 requested a review from a team November 26, 2024 16:23
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (f88a3eb) to head (bfc120d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10078      +/-   ##
==========================================
- Coverage   89.37%   89.37%   -0.01%     
==========================================
  Files         294      294              
  Lines       31283    31289       +6     
==========================================
+ Hits        27960    27965       +5     
- Misses       3323     3324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 74ddcf2 into rust-lang:main Nov 29, 2024
10 checks passed
@Turbo87 Turbo87 deleted the per-version-cats-and-keys branch November 29, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants