fix(package): show dirty filepaths relative to git workdir #14968
+143
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make error message more deterministic
rustbot
added
Command-package
S-waiting-on-review
epage
approved these changes
Dec 19, 2024
|
This doesn't matter for stable I think the ideal solution is to be relative to the current directory but that takes more work and this incremental improvement is great! |
We have the |
weihanglo
added a commit
to weihanglo/cargo
that referenced
this pull request
Dec 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
### What does this PR try to resolve? Address #14968 (comment) > I think the ideal solution is to be relative to the current directory but that takes more work and this incremental improvement is great! Sorry I should have noticed your comment earlier.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 21, 2024
Update cargo 10 commits in 99dff6d77db779716dda9ca3b29c26addd02c1be..652623b779c88fe44afede28bf7f1c9c07812511 2024-12-18 00:55:17 +0000 to 2024-12-20 15:44:42 +0000 - fix(package): use relpath to cwd for vcs dirtiness report (rust-lang/cargo#14970) - Enable triagebot merge conflict notifications (rust-lang/cargo#14972) - fixed the error message for a user to open the crate (rust-lang/cargo#14969) - fix(package): show dirty filepaths relative to git workdir (rust-lang/cargo#14968) - Add the `test` cfg as a well known cfg before of compiler change (rust-lang/cargo#14963) - refactor(cargo-package): let-else to flatten code (rust-lang/cargo#14959) - fix(cargo-package): add more traces (rust-lang/cargo#14960) - Do not hash absolute sysroot path into stdlib crates metadata. (rust-lang/cargo#14951) - docs: add missing argument to Rustup Cargo workaround (rust-lang/cargo#14954) - fix(cargo-rustc): stabilize higher precedence trailing flags (rust-lang/cargo#14900)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Dirty file paths in the original message were stripped relative to package root.
User is not able to know the full path to find dirty files.
This PR makes it relative to git workdir.
How should we test and review this PR?
This was found during #14962