Hash paths relative to the workspace into metadata. #14953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @weihanglo this is related to #14951 , also #13586 (comment) |
|
Can we make sure this has a test? I'm not sure if the intent here is to ensure it stays consistent if the tree is moved, perhaps just a freshness test would suffice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Cargo hashes the relative path if it's under the workspace root,
or absolute if it isn't.
This causes non-reproducibility problems when using dependencies like
path = "../foo"that point to crates outside the workspace (or when not using a workspace at all).
This PR fixes the problem by making all paths relative to the workspace root, not
just paths under it.
Fixes #13586