Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(build): finish to log compilied pkg. #14865

Closed
wants to merge 2 commits into from

Conversation

damonxue
Copy link

This pull request includes a little change to the DrainState implementation in the src/cargo/core/compiler/job_queue/mod.rs file. The change enhances the logging and tracking of the job queue's progress by adding detailed logging for different types of artifacts.

Enhancements to logging and tracking:

  • src/cargo/core/compiler/job_queue/mod.rs: Added detailed logging for the completion of a unit of work, including specific statuses for documentation, scraping, and compilation. This helps in tracking the progress of the job queue more effectively.

@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2024
@damonxue damonxue closed this Nov 28, 2024
@weihanglo
Copy link
Member

Saw you just closed it, though thanks for the contribution anyway!

The major issue of console output overhaul is #8889, which you might be interested in. One of complaint is the current output too noisy, which is on the opposite side of this PR.

@damonxue damonxue deleted the dev_log branch November 28, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-execution Area: anything dealing with executing the compiler S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants