Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch17-05: Typos #4099

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ch17-05: Typos #4099

wants to merge 2 commits into from

Conversation

jpmelos
Copy link
Contributor

@jpmelos jpmelos commented Nov 10, 2024

1

[...] Instead, Rust needs makes sure that the loop [...]

to

[...] Instead, Rust makes sure that the loop [...]

2

[...] The signature for join_all produces requires that the type [...]

to

[...] The signature for join_all requires that the type [...]

3

[...] we need a mutable reference to the type, which is wrapped in a Pin. [...]

to

[...] we need a mutable reference to the type which is wrapped in a Pin. [...]

Here's proof that this change is adequate:

2024-11-10_11-41

@chriskrycho
Copy link
Contributor

These look good overall, but please do drop the comma change, and please do not cite ChatGPT or any other generative AI tool when it comes to style in general and comma style in particular. Our editors at NoStarch will make sure that’s aligned with their house style, which is the thing we prioritize here. Thanks!

@jpmelos
Copy link
Contributor Author

jpmelos commented Nov 12, 2024

Got it, I reverted the comma change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants