Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve poor filename filtering feedback to user #252

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve poor filename filtering feedback to user #252

wants to merge 5 commits into from

Commits on Nov 29, 2022

  1. core: show drawbacks of file filtering with regex 

    * refinery_cli will silently skip filenames like "V1__first.base.rs" or "V2__second-base.rs"  without any logging/feedback to the user
  * user should be made aware what exactly is wrong with his filenames

* refinery will allow filenames like "V1.5__first.base.rs" with decimal version numbers and will try to convert them into integers.
  * refinery's database table stores versions as integers
    @lw2011
    Lukasz Wisniowski authored and lw2011 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d4736ea View commit details
    Browse the repository at this point in the history

  2. core: inform user about formatting errors 

    * Feeds nice error messages to the user.
* Before the change runner would not have a chance to inspect the
  formatting of input name.
    @lw2011
    Lukasz Wisniowski authored and lw2011 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    13d40ed View commit details
    Browse the repository at this point in the history

  3. macros: pass full filename to Migration::unapplied

    @lw2011
    lw2011 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a37cd7d View commit details
    Browse the repository at this point in the history

  4. test: pass full filename in all tests 

    * including file's extension
    @lw2011
    lw2011 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    4a47ee2 View commit details
    Browse the repository at this point in the history

  5. cli: use more specific error messages

    @lw2011
    lw2011 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    e017426 View commit details
    Browse the repository at this point in the history