Bump the MSRV #719
Bump the MSRV #719
Conversation
tcharding
force-pushed
the
08-06-bump-msrv
branch
from
c286487 to
7168078
Compare
|
As you did with other bumps, you forget to update the README 😂 |
tcharding
force-pushed
the
08-06-bump-msrv
branch
from
7168078 to
0d4dc7e
Compare
|
Damn, I have a grep alias that ignores md files - I have to remember not to use it when doing MSRV bumps. Thanks man. |
tcharding
force-pushed
the
08-06-bump-msrv
branch
from
0d4dc7e to
add2fc3
Compare
tcharding
force-pushed
the
08-06-bump-msrv
branch
from
add2fc3 to
34943ea
Compare
|
Force push is just a change to the docs on the MSRV job, sorry to require re-ack @storopoli (found while rebaseing #694). |
|
Could you add a commit to the start of this which bumps the honggfuzz dep in both lockfiles? It doesn't really have anything to do with this PR but it's a "toolchain update" and it'd simplify my local CI runs. |
tcharding
force-pushed
the
08-06-bump-msrv
branch
2 times, most recently
from
c1c7587 to
3916522
Compare
|
I'm not sure why the hongfuzz change causes |
|
6a56d37 seems weird, and it bumps the versions of stuff in Cargo-minimal.lock that should continue to work. I'd prefer you just updated And the reason why is that honggfuzz is both a dependency and a binary that the developer needs to have installed on their system, and the versions of these two things need to match exactly, and my CI scripts have the latest version since we updated rust-bitcoin and others. And also the latest version fixes a bug with |
|
Ah I see, thanks for the explanation. Will re-spin |
A recent patch version of `hongfuzz` fixed a bug with `memcpy`, we likely do not want users using the old version. Upgrade by first pinning then by patching the manifest.
As we have done in `rust-bitcoin` bump the MSVR to Rust 1.63.0 While we are at it and so that the commit lints cleanly fix a couple of new clippy warnings: - Remove redundant import of `TryFrom` - Use `then_some` combinator
Currently we are not running the MSRV job with both lock files, we should. Note also that the lock files are different, testing older versions of `hashes` and `internals` - this is because of the range dependency in `secp` (I think).
tcharding
force-pushed
the
08-06-bump-msrv
branch
from
3916522 to
c95b411
Compare
|
Want me to do a release PR? |
|
No, I just released 12.2 right before merging this. |
As we have done in
rust-bitcoinbump the MSVR to Rust 1.63.0Also, run the MSRV CI job with both lockfiles (which are currently different).