Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 11.x of #704 #706

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Backport 11.x of #704 #706

merged 3 commits into from
Jul 14, 2024

Conversation

sanket1729
Copy link
Member

No description provided.

@apoelstra
Copy link
Member

Can you change the CHANGELOG to drop the thing about LoggerAssetProvider because I don't think that's true of the backports.

@sanket1729
Copy link
Member Author

@apoelstra done

@sanket1729
Copy link
Member Author

@apoelstra this is still unreleased.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fd823e8

@apoelstra
Copy link
Member

Yep, sorry -- was hacking on my local CI to get it to work with 11.x -- but I was able to succeed, which is great. We have far better QA now on our backports than we used to. And after #682 I think that going forward, actual github CI should work for 12.x forever.

Can we do a backport to 9.x? Then we should be done as far as we intend to go.

@sanket1729
Copy link
Member Author

Can we do a backport to 9.x?

On it. Will do in an hour or so

@apoelstra apoelstra merged commit 2f1a262 into rust-bitcoin:release-11.x Jul 14, 2024
1 of 16 checks passed
@apoelstra
Copy link
Member

Tagged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants