This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Implement into_model
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
06-17-features
branch
2 times, most recently
from
4aff188 to
bf50047
Compare
Add a convenience functions to the `GenerateToAddress` model type to get the number of blocks generated.
For all `json` types implement an inherent `into_model` function and remove the `TryInto` implementations. Done to improve ergonomics. Patch includes a bunch of other cleanups and improvements on the way.
tcharding
force-pushed
the
06-17-features
branch
from
bf50047 to
d0e052d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the usage more ergonomic by implementing
into_modelon eachjsontype and also add some helper accessor functions.