Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Move macro call #46

Closed

Conversation

tcharding
Copy link
Member

During development of the v28 support we re-ordered some macro calls, so as not to hold up an external contributor with triviality I acked and merged as it was.

Put the macro calls in the same order so that when one diffs v27_api.rs and v28_api.rs there are no false positives in the diff.

Internal change only.

During development of the v28 support we re-ordered some macro calls,
so as not to hold up an external contributor with triviality I acked
and merged as it was.

Put the macro calls in the same order so that when one diffs
`v27_api.rs` and `v28_api.rs` there are no false positives in the
diff.

Internal change only.
@tcharding
Copy link
Member Author

Hmm, that is a surprising CI failure.

@tnull
Copy link
Contributor

tnull commented Nov 12, 2024

Btw, related to "move" and "macro call": it seems that since all macros include separate impl blocks the docs render pretty weirdly. Might be worth dropping these impl blocks and only adding them once in the respective module that uses the macros.

@tcharding
Copy link
Member Author

the docs render pretty weirdly

Which docs? This whole crate is pretty weird, so I'm not totally surprised no matter which docs you link me to. The Client docs seem to be reasonably normal.

https://docs.rs/bitcoind-json-rpc-regtest/0.3.0/bitcoind_json_rpc_regtest/struct.Client.html

Might be worth dropping these impl blocks and only adding them once in the respective module that uses the macros

The whole point of the macros is that they are used in every version (goes for the test macros and the client macros.

Or am I misunderstanding you?

@tnull
Copy link
Contributor

tnull commented Nov 14, 2024

seem to be reasonably normal.

Well, other than the docs are broken up as each method listed has its own impl Client section. :)

@tcharding
Copy link
Member Author

Oh yeah I see, I did not notice that before.

@tcharding tcharding closed this Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants