Add support for Bitcoin Core v28

[tnull]

Based on #21.

Currently still work in progress (as v28.0rc1 has just been released, so no final binaries are available etc).

Ready for review.

[tcharding]

Thanks for working on this man. Can you pull the formatting changes out please, I was surprised to see changes to the json/src/v17 files. Also, did you get the contents of rpc-ap.txt from running bitcoin-cli help against a Core v28 instance or did you copy'paste for another existing file? (EDIT: Oh submitpackage only exists in v28 so you must have used bitcoin-cli :)

I merged #22 so you can rebase when you feel like it. Cheers

[tnull]

Thanks for working on this man. Can you pull the formatting changes out please, I was surprised to see changes to the json/src/v17 files.

Ah, now dropped them, didn't realize they slipped in as I didn't expect it either.

Also, did you get the contents of rpc-ap.txt from running bitcoin-cli help against a Core v28 instance or did you copy'paste for another existing file? (EDIT: Oh submitpackage only exists in v28 so you must have used bitcoin-cli :)

Jup, run bitcoin-cli (took me a while to get where rpc-api.txts are coming from though :)

I merged #22 so you can rebase when you feel like it. Cheers

Cool, rebased for now, will resume work ~end of this week.

[tcharding]

(took me a while to get where rpc-api.txts are coming from though :)

Ha! So we need a "How to add support for a new version" doc. I'd love a script to check that all the rpc-ap.txt files actually come from bitcoin-cli help > rpc-api.txt for the correct version of Core and are not just copied from another file. Yesterday I was looking at the wrong buffer in my editor and thought I'd made a mistake so went back and checked manually. It would be nice to check that the mod.rs rustdoc is using the correct rpc-api.txt content as well, as it is we just have to hope I didn't get mixed up :)

[tcharding]

We should be right to get this in now mate if you have clockcycles free to work in it?

• Needs pub mod v28 in client/src/client_sync/mod.rs
• Needs the SHA file from https://bitcoincore.org/bin/bitcoin-core-28.0/
• Two tests are failing when running cargo test --features=28_0 (in integration tests).

[tnull]

We should be right to get this in now mate if you have clockcycles free to work in it?

Yes, excuse the delay here, I was busy with other stuff since v28 was released. Given that that's done now, will see to make some progress here this week.

[tcharding]

No stress, and no rush.

[tnull]

We should be right to get this in now mate if you have clockcycles free to work in it?

* Needs `pub mod v28` in `client/src/client_sync/mod.rs`

* Needs the SHA file from https://bitcoincore.org/bin/bitcoin-core-28.0/

* Two tests are failing when running `cargo test --features=28_0` (in integration tests).

Alright, now added the final SHA file for 28.0 and fixed the tests/RPC changes in getnetworkinfo and getblockchain info.
Should be ready for review, let me know if I can squash the fixup commits.

[tcharding]

looks good man, yes please squash it down.

[tnull]

looks good man, yes please squash it down.

Squashed without further changes.

[tcharding]

ACK fcd9696

[tcharding]

Thanks man, you are the first person apart from me to patch this repo - super cool! I hope you find this crate useful.

[tcharding]

Hey @tnull are you waiting on this to release? I got g'd up by #48 and released the crates, I meant to release 0.3 without the new stuff but I botched it and ended up releasing 0.4 with your Coer v28 stuff.

My question to you is, do you want me to do a 0.4 release of this as is before the rename (assuming the rename goes through)?

[tnull]

Hey @tnull are you waiting on this to release?

Nope, no worries! Where we have bitcoind RPC support we so far had our own types working, and we're not in a rush to switch at all.