Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking PR: v0.19.0 #345

Merged
merged 2 commits into from
May 14, 2024

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented May 1, 2024

In preparation for release add a changelog entry and bump the version number.

Patch 1 is a trivial cleanup of an old stale changelog file, no longer used.

@tcharding tcharding force-pushed the 05-01-release-0.19.0 branch 2 times, most recently from adad308 to 2ce36cc Compare May 1, 2024 03:10
@tcharding tcharding changed the title Release trackcing PR: v0.19.0 Release tracking PR: v0.19.0 May 1, 2024
@tcharding tcharding added this to the v0.19.0 milestone May 1, 2024
@tcharding tcharding force-pushed the 05-01-release-0.19.0 branch from 2ce36cc to f42bbd9 Compare May 7, 2024 23:09
@tcharding tcharding force-pushed the 05-01-release-0.19.0 branch from f42bbd9 to 6852585 Compare May 13, 2024 22:33
@tcharding
Copy link
Member Author

tcharding commented May 14, 2024

All PRs in the todo list are ready to merge, lets get this release out!

We use a single changlog for both `client` and `json` but there is an
old stale changelog file sitting inside `client/` - remove it.
@tcharding tcharding force-pushed the 05-01-release-0.19.0 branch from 6852585 to 5c09648 Compare May 14, 2024 22:16
@tcharding tcharding marked this pull request as ready for review May 14, 2024 22:17
@tcharding
Copy link
Member Author

Don't merge yet!

In preparation for release add a changelog entry and bump the version
number.
@tcharding tcharding force-pushed the 05-01-release-0.19.0 branch from 5c09648 to 839fcb6 Compare May 14, 2024 22:20
@tcharding
Copy link
Member Author

tcharding commented May 14, 2024

ok, looks good now. I did:

  • cargo publish -p bitcoincore-rpc-json --dry-run and that succeeds
  • cargo publish -p bitcoincore-rpc --dry-run fails because the bitcoincore-rpc-json crate doesn't exist (yet).

FTR the glitch above was we have to include the explicit version number of json in client/Cargo.toml when publishing - I previously removed it.

@tcharding
Copy link
Member Author

If you merge @apoelstra I'll tag and publish both crates.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 839fcb6

@apoelstra apoelstra merged commit 06a6c15 into rust-bitcoin:master May 14, 2024
13 checks passed
@apoelstra
Copy link
Member

Ok, merged. Go for it!

@tcharding
Copy link
Member Author

Damn, damn, damn, damn, damn - I've only got publish perms on bitcoincore-rpc on on bitcoincore-rpc-json.

CC @stevenroose

@tcharding
Copy link
Member Author

Further explanation: Steven gave me perms on one crate so I could publish but we forgot the other, bitcoincore-rpc release requires a release of bitocincore-rpc-json first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants