Remove arbitrary padding limit #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
force-pushed
the
no-padding-limit
branch
from
77de51a to
b215981
Compare
When formatting a slice as hex an arbitrary limit of 512 chars was applied to decide whether to pad it. This was silent and surprising so this commit fixes it by removing the limit. It implements padding manually with moderate optimizations.
Kixunil
force-pushed
the
no-padding-limit
branch
from
b215981 to
8569ee8
Compare
apoelstra
reviewed
Oct 28, 2023
| fmt::Alignment::Center => | ||
| ((width - string_len) / 2, (width - string_len + 1) / 2), | ||
| }; | ||
| // Avoid division by zero and optimize for common case. |
There was a problem hiding this comment.
In 8569ee8:
Here and below I don't think there is any actual division by 0. There would be "dividing 0 by something" but this is harmless.
There was a problem hiding this comment.
chunk_len is 0 if the input to put_filler is 0. I actually got panics for that, unfortunately I wasn't smart enough to see it first. :)
There was a problem hiding this comment.
Lol, me neither apparently :)
apoelstra
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When formatting a slice as hex an arbitrary limit of 512 chars was applied to decide whether to pad it. This was silent and surprising so this commit fixes it by removing the limit. It implements padding manually with moderate optimizations.
(The limit was introduced in #25 )