Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kix's name to the authors list #39

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Oct 27, 2023

If one looks at crates.io or the git index it looks like I wrote this crate but that is wholeheartedly untrue, Kix wrote almost all the code in this crate IIRC. I just pulled it all out of rust-bitcoin.

Put Kixunil's name at the front of the author's list. Leave Andrew's there in second place because he is the crate owner, and reviewed everything. Omit my name because I have only chopped and changed trivial things and am only likely to polish things going forwards.

If one looks at crates.io or the git index it looks like I wrote this
crate but that is wholeheartedly untrue, Kix wrote almost all the code
in this crate IIRC. I just pulled it all out of `rust-bitcoin`.

Put Kixunil's name at the front of the author's list. Leave Andrew's
there in second place because he is the crate owner, and reviewed
everything. Omit my name because I have only chopped and changed trivial
things and am only likely to polish things going forwards.
@tcharding
Copy link
Member Author

I'm pretty sure Kix is watching this repo but for other's watching along, mention @Kixunil.

Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2de7cc8

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2de7cc8

@apoelstra apoelstra merged commit d2cfecb into rust-bitcoin:master Oct 27, 2023
9 checks passed
@tcharding tcharding deleted the 10-27-authors branch November 1, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants