Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict BufEncoder to uniform case encoding #119

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Restrict BufEncoder to uniform case encoding #119

merged 1 commit into from
Oct 28, 2024

Conversation

tankyleo
Copy link
Contributor

The API now enforces that all hex strings encoded with BufEncoder contain characters of the same case.

@tankyleo
Copy link
Contributor Author

This breaks the API.

It seems to me that the case where BufEncoder yields a hex string with varying cases is a bug, so we can prevent this from happening using this API as far as I see.

@apoelstra
Copy link
Member

Neat. I'll ACK this but let @Kixunil chime in (or at least, give him a week or two) to see if there was a reason for the existing API to be what it was. This definitely seems like an improvement.

apoelstra
apoelstra approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fbab80e successfully ran local tests

tcharding
tcharding approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fbab80e

@tcharding
Copy link
Member

Thanks man, you are doing some nice work here.

@tankyleo
Copy link
Contributor Author

Rebase: fix merge conflict.

apoelstra
apoelstra approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 54d2520 successfully ran local tests

tcharding
tcharding approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 54d2520

@tcharding tcharding mentioned this pull request Oct 15, 2024
Merged
@tankyleo tankyleo mentioned this pull request Oct 15, 2024
Merged
@tankyleo
Restrict BufEncoder to uniform case encoding
b57f327 
The API now enforces that all hex strings encoded with `BufEncoder`
contain characters of the same case.
@tankyleo
Copy link
Contributor Author

Rebase: fix merge conflict.

apoelstra
apoelstra approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b57f327; successfully ran local tests

tcharding
tcharding approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b57f327

@apoelstra apoelstra merged commit 2e86574 into rust-bitcoin:master Oct 28, 2024
13 checks passed
@tankyleo tankyleo deleted the bufencoder-uniform-case branch October 31, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcharding tcharding tcharding approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tankyleo @apoelstra @tcharding