Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing args in envvars #23

Closed
wants to merge 1 commit into from
Closed

allow passing args in envvars #23

wants to merge 1 commit into from

Conversation

redthing1
Copy link

closes #22

@finefoot
Copy link
Contributor

Why not user password, too?

@redthing1
Copy link
Author

@finefoot Yours (#20) looks better. It's trivial to pass environment variables as arguments via the shell so I think that is the best solution.

@finefoot
Copy link
Contributor

It's trivial to pass environment variables as arguments via the shell so I think that is the best solution.

Yes, that's true. However, sometimes, it's not the safest way to pass arguments: https://unix.stackexchange.com/questions/85466/how-to-see-process-created-by-specific-user-in-unix-linux On the other hand, environment variables can be considered a lot more secret than arguments to a command line call: https://security.stackexchange.com/questions/14000/environment-variable-accessibility-in-linux/14009#14009 So your proposition to add support for environment variables makes sense in any case. 👍

@russelldavies
Copy link
Owner

When I wrote this utility the use case in mind was that people would run this script once when they were switching or decommissioning a homeserver. It seems that quite a few people want to have this running continuously, I'm guessing as a backup strategy. So I'll be reorganizing how the archiver works. I'm thinking of making it run more like a daemon process with a config file.

So thanks for your pull request but I'm not going to merge it, rather take elements of it and use those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Allow passing arguments via environment variables
3 participants