allow eval expressions for icon-image and fill-image #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerDakon
force-pushed
the
icon-eval
branch
3 times, most recently
from
4f79ec5
to
c249f6b
Compare
DerDakon
force-pushed
the
icon-eval
branch
2 times, most recently
from
5a0223f
to
0286ec3
Compare
DerDakon
force-pushed
the
icon-eval
branch
2 times, most recently
from
c5168bb
to
9a7437c
Compare
DerDakon
force-pushed
the
icon-eval
branch
2 times, most recently
from
31b5c6b
to
61b79c8
Compare
DerDakon
force-pushed
the
icon-eval
branch
2 times, most recently
from
7174f0c
to
dd12874
Compare
If those tags contained an eval expression those would erroneously be taken as a filename, leading to a parse error. Simply check if the expression is an eval before calling the filename handling. This does not make it really work, but it at least does not crash anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If those tags contained an eval expression those would erroneously be taken as a filename, leading to a parse error. Simply check if the expression is an eval before calling the filename handling.
This does not make it really work, but it at least does not crash anymore.
This does not fix #28, but is the first step in that direction.