Psych.loadの引数filenameの追従 #2870
Merged
Psych.loadの引数filenameの追従 #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishidayuya
commented
Feb 8, 2024
refm/api/src/psych.rd
Outdated
| @@ -113,7 +113,16 @@ libyaml のバージョンを返します。 | |||
| @see [[m:Psych::LIBYAML_VERSION]] | |||
|
|
|||
| #@since 2.5.0 | |||
| #@since 2.6.0 | |||
| #@since 3.1 | |||
There was a problem hiding this comment.
このあたりの分岐についてはより良い方法がありましたらご教示ください
There was a problem hiding this comment.
こんな感じですかね
#@if("2.6.0" <= version)
--- load(yaml, filename: nil, fallback: false, symbolize_names: false) -> object
#@end
#@if("2.5.0" <= version and version < "3.1")
--- load(yaml, filename = nil, fallback: false, symbolize_names: false) -> object
#@end
#@if(version < "2.5.0")
--- load(yaml, filename = nil, fallback = false) -> object
#@end
There was a problem hiding this comment.
ご提示ありがとうございました． 7f8b1c9 として積ませていただきました．
nishidayuya
force-pushed
the
follow_psych_load_argument_change
branch
2 times, most recently
from
2cd5605 to
0acb12d
Compare
|
ご確認ありがとうございました． CIが通らなかった点を調べないとなどと考えていましたが， 58b73ef で修正されたと見受けました．ご対応ありがとうございました． 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下の対応を行いました．
動作確認
以下のようになることを確認しました．
ruby-3.1
ruby-3.0
ruby-2.6.0
ruby-2.5.0
ruby-2.4.0