Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.3 から Regexp.new の第三引数が削除されたので対応する #2867

Merged

Conversation

osyo-manga
Copy link
Contributor

@osyo-manga osyo-manga commented Jan 10, 2024

Ruby 3.3 で Regexp.new の第三引数が削除されたのでそれを反映させました。

Regexp.new("this is regexp", Regexp::IGNORECASE, "n")
# Ruby 3.2 => no error
# Ruby 3.3 => error: wrong number of arguments (given 3, expected 1..2) (ArgumentError)

参照: Bug #18797: Third argument to Regexp.new is a bit broken - Ruby master - Ruby Issue Tracking System

参照: [Bug #18797: Third argument to Regexp.new is a bit broken - Ruby master - Ruby Issue Tracking System](https://bugs.ruby-lang.org/issues/18797)
@osyo-manga osyo-manga marked this pull request as ready for review January 10, 2024 11:31
Copy link
Member

@znz znz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

差分があるところだけ分岐した方が良いかとも思いましたが、これでもよさそうだと思ったのでマージします。

@znz znz merged commit 3a6b155 into rurema:master May 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants