Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TracePoint#bindingの戻り値の型をRuby 3.2以降で変更 #2840

Merged
merged 2 commits into from
Nov 2, 2023
Merged

TracePoint#bindingの戻り値の型をRuby 3.2以降で変更 #2840

merged 2 commits into from
Nov 2, 2023

Conversation

kyanagi
Copy link
Contributor

@kyanagi kyanagi commented Oct 24, 2023

#2838 の続きです。

@kyanagi kyanagi mentioned this pull request Oct 24, 2023
Merged
znz
znz requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@znz znz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

分岐は #@since と #@else の組み合わせを使っているところがほとんどなので、それでお願いします。

@kyanagi
Copy link
Contributor Author

kyanagi commented Oct 25, 2023

ありがとうございます。修正しました。

znz
znz approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@znz znz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。

@znz znz merged commit caca167 into rurema:master Nov 2, 2023
8 checks passed
@kyanagi kyanagi deleted the fix_tracepoint_binding_return_type branch November 2, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znz znz znz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyanagi @znz