Removed problematic float filter from a utility method

runz0rd · Nov 23, 2016 · d9bbe52 · d9bbe52
1 parent 25f0147
commit d9bbe52
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Common/Util/Iteration.php b/src/Common/Util/Iteration.php
@@ -76,7 +76,6 @@ public static function typeFilter($source) {
         else {
             $source = Validation::filterInteger($source);
             $source = Validation::filterBoolean($source);
-            $source = Validation::filterFloat($source);
         }
 
         return $source;

diff --git a/src/Common/Util/Validation.php b/src/Common/Util/Validation.php
@@ -98,12 +98,13 @@ public static function filterBoolean($value) {
 
     /**
      * Returns a casted float or the original value
+     * This one isnt reliable, dont use
      * @param mixed $value
      * @return float|mixed
      */
     public static function filterFloat($value) {
         $floatValue = filter_var($value, FILTER_VALIDATE_FLOAT);
-        if($floatValue !== false && is_string($value)) {
+        if($floatValue !== false && is_string($value) && preg_match('[.|,]', $value)) {
             $value = $floatValue;
         }