Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linux runners #683

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

pendo324
Copy link
Member

Issue #, if available:
Adding Linux e2e test runners In support of runfinch/finch#1023

Description of changes:

  • Adds Amazon Linux 2 and 2023 runners
    • Only added for finch repo for now, because there's no value in testing finch-core changes on Linux as they do not impact finch on linux functionality
  • User data setup script configured in a way that makes it easy to extend support to other Linux varieties

Testing done:

  • Unit tests

  • Tested in my own stack

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Justin Alvarez <[email protected]>
@pendo324 pendo324 self-assigned this Aug 14, 2024
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for grabbing the formatting and keypair deprecation as well.

scripts/setup-linux-runner.sh Outdated Show resolved Hide resolved
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Thanks.

@pendo324 pendo324 merged commit 0b281b0 into runfinch:main Sep 13, 2024
2 checks passed
pendo324 added a commit to runfinch/finch that referenced this pull request Sep 18, 2024
build(linux): add Linux packaging and e2e tests (#1071)

- Add packaging and e2e runners which use the packages to run tests
- Before merging this, we need to:
  - add linux runners to this repository (by merging runfinch/infrastructure#683)
  - remove the change in this PR which makes it so CI runs on all branches, not just main
  - uncomment the disabling of the macOS/Windows runners

Signed-off-by: Justin Alvarez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants