fix: Fix to allow users to configure disk size for finch space

README.md

@@ -145,6 +145,9 @@ vmType: "qemu"
 # Only available when using vmType "vz" on Apple Silicon running macOS 13+.
 # If true, also sets vmType to "vz".
 rosetta: false
+# finchDiskSize: the amount of disk size allocated for finch space in the virtual machine. (optional)
+# Only takes effect when a new VM is launched (only on vm init).
+finchDiskSize: 50GB
 ```
 
 ### FAQ

e2e/vm/additional_disk_test.go

@@ -8,6 +8,7 @@ import (
 
 	"github.com/onsi/ginkgo/v2"
 	"github.com/onsi/gomega"
+	"github.com/onsi/gomega/gexec"
 	"github.com/runfinch/common-tests/command"
 	"github.com/runfinch/common-tests/option"
 )
@@ -19,7 +20,7 @@ const (
 	networkName   = "test-network"
 )
 
-var testAdditionalDisk = func(o *option.Option) {
+var testAdditionalDisk = func(o *option.Option, installed bool) {
 	ginkgo.Describe("Additional disk", ginkgo.Serial, func() {
 		ginkgo.It("Retains container user data after the VM is deleted", func() {
 			command.Run(o, "volume", "create", volumeName)
@@ -56,5 +57,13 @@ var testAdditionalDisk = func(o *option.Option) {
 			gomega.Expect(command.StdoutStr(o, "exec", containerName, "cat", "/tmp/test.txt")).
 				Should(gomega.Equal("foo"))
 		})
+
+		ginkgo.It("should correctly configure disk size as specified in finch.yaml", func() {
+			resetVM(o, installed)
+			resetDisks(o, installed)
+			writeFile(finchConfigFilePath, []byte("cpus: 6\nmemory: 4GiB\nvmType: qemu\nrosetta: false\nfinchDiskSize: 3GB"))
+			initCmdSession := command.New(o, virtualMachineRootCmd, "init").WithTimeoutInSeconds(600).Run()
+			gomega.Expect(initCmdSession).Should(gexec.Exit(0))
+		})
 	})
 }

e2e/vm/vm_test.go

@@ -46,7 +46,7 @@ func TestVM(t *testing.T) {
 
 	ginkgo.Describe("", func() {
 		testVMLifecycle(o)
-		testAdditionalDisk(o)
+		testAdditionalDisk(o, *e2e.Installed)
 		testConfig(o, *e2e.Installed)
 		testFinchConfigFile(o)
 		testVersion(o)

pkg/config/config.go

@@ -55,6 +55,9 @@ type Finch struct {
 	// Has no effect on systems where Rosetta 2 is not available (Intel/AMD64 macs, or macOS < 13.0).
 	// This setting will only be applied on vm init.
 	Rosetta *bool `yaml:"rosetta,omitempty"`
+	// FinchDiskSize: the amount of disk size allocated for finch space in the virtual machine.
+	// This setting will only be applied on vm init.
+	FinchDiskSize *string `yaml:"finchDiskSize,omitempty"`
 }
 
 // Nerdctl is a copy from github.com/containerd/nerdctl/cmd/nerdctl/main.go

pkg/disk/disk.go

@@ -11,6 +11,7 @@ import (
 	"io/fs"
 	"path"
 
+	"github.com/docker/go-units"
 	limaStore "github.com/lima-vm/lima/pkg/store"
 	"github.com/spf13/afero"
 
@@ -22,9 +23,11 @@ import (
 const (
 	// diskName must always be consistent with the value under additionalDisks in finch.yaml.
 	diskName = "finch"
-	diskSize = "50G"
 )
 
+// the amount of disk size allocated for finch space in the virtual machine.
+var diskSize = "50G"
+
 // UserDataDiskManager is used to check the user data disk configuration and create it if needed.
 type UserDataDiskManager interface {
 	EnsureUserDataDisk() error
@@ -191,6 +194,13 @@ func (m *userDataDiskManager) convertToRaw(diskPath string) error {
 }
 
 func (m *userDataDiskManager) createLimaDisk() error {
+	if m.config.FinchDiskSize != nil {
+		_, err := units.RAMInBytes(*m.config.FinchDiskSize)
+		if err != nil {
+			return err
+		}
+		diskSize = *m.config.FinchDiskSize
+	}
 	cmd := m.lcc.CreateWithoutStdio("disk", "create", diskName, "--size", diskSize, "--format", "raw")
 	if logs, err := cmd.CombinedOutput(); err != nil {
 		return fmt.Errorf("failed to create disk, debug logs:\n%s", logs)