Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct linter integrations url; add GOPROXY note #1067

Merged
merged 1 commit into from
Aug 20, 2024
+3 −1
Merged

docs: correct linter integrations url; add GOPROXY note #1067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ This section describes how one can develop Finch CLI locally, build it, and then

We use [golangci-lint](https://github.com/golangci/golangci-lint).

To integrate it into your IDE, please check out the [official documentation](https://golangci-lint.run/usage/integrations/).
To integrate it into your IDE, please check out the [official documentation](https://golangci-lint.run/welcome/integrations/).

For more details, see [`.golangci.yaml`](./.golangci.yaml) and the `lint` target in [`Makefile`](./Makefile).

Expand Down Expand Up @@ -185,6 +185,8 @@ Then run `make` to build the binary. The binary in `_output` can be directly use

You can run `make install` to make finch binary globally accessible.

NOTE: If your build environment experiences issues with downloading dependencies from the Go proxy servers, then you may want to set the environment variable `export GOPROXY=direct`

### Unit Testing

To run unit test locally, please run `make test-unit`. Please make sure to run the unit tests before pushing the changes.
Expand Down