Skip to content

Commit

Permalink
fix: remove llvm copy to fix build errors (#1030)
Browse files Browse the repository at this point in the history
Issue #, if available:

*Description of changes:*
remove llvm copy as the step is not required and was causing
inconsistent build failures

*Testing done:*
Local Testing and pipeline test


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Shubharanshu Mahapatra <[email protected]>
  • Loading branch information
Shubhranshu153 authored Jul 11, 2024
1 parent dcb3865 commit 5104857
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ UNAME := $(shell uname -m)
ARCH ?= $(UNAME)
SUPPORTED_ARCH = false
LICENSEDIR := $(OUTDIR)/license-files
VERSION := $(shell git describe --match 'v[0-9]*' --dirty='.modified' --always --tags)
VERSION ?= $(shell git describe --match 'v[0-9]*' --dirty='.modified' --always --tags)
GITCOMMIT := $(shell git rev-parse HEAD)$(shell test -z "$(git status --porcelain)" || echo .m)
LDFLAGS = "-w -X $(PACKAGE)/pkg/version.Version=$(VERSION) -X $(PACKAGE)/pkg/version.GitCommit=$(GITCOMMIT)"
MIN_MACOS_VERSION ?= 11.0
Expand Down
6 changes: 0 additions & 6 deletions installer-builder/tools/extract-executables.sh
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ extractExecutables() {
newpath="./installer-builder/output/executables/unsigned/package/artifact/EXECUTABLES_TO_SIGN/$newname"
cp -a "$1/$file" "$newpath"
codesign --remove-signature "$newpath"
"$(brew --prefix)"/opt/llvm/bin/llvm-objcopy \
--keep-undefined \
--add-section \
__TEXT,__info_plist=./installer-builder/darwin/Info.plist \
"$newpath" \
"$newpath"
#qemu needs specific entitlement, handle it separately
if [[ $file == "qemu-system-x86_64" || $file == "qemu-system-aarch64" ]];
then
Expand Down

0 comments on commit 5104857

Please sign in to comment.