-
Notifications
You must be signed in to change notification settings - Fork 95
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Fix to be able to run finch build with --ssh option (#696)
In the current implementation, the following error occurs when running finch build with the `--ssh default` option. This issue is also reported in issue/452. ``` error: invalid empty ssh agent socket: make sure SSH_AUTH_SOCK is set FATA[0000] no image was built FATA[0000] exit status 1 ``` This is because the ssh agent is not starting on the vm started using lima and the SSH_AUTH_SOCK variable is empty. As a result, this error occurs. On the other hand, setting forwardAgent to true in finch.yaml will configure the vm to forward the ssh agent. As a result, the ssh agent will be started in the vm and finch build can be executed using the `--ssh default` option. Therefore, this commit will fix it so that finch build can be run using the `--ssh default` option. Issue #, if available: #452 *Description of changes:* Details are described in commit messages. *Testing done:* Yes, confirmation of the operation is added in the comments of the issue below. - #452 (comment) - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Hayato Kiwata <[email protected]>
- Loading branch information
Showing
3 changed files
with
10 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters