Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for pidfile #90

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

Shubhranshu153
Copy link
Contributor

Issue #, if available:

Description of changes:
Add support for pidfile.

Testing done:

  1. Start finch daemon with pidfile option and check if file is created.
  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides a couple nits

cmd/finch-daemon/main.go Outdated Show resolved Hide resolved
cmd/finch-daemon/main.go Outdated Show resolved Hide resolved
cmd/finch-daemon/main.go Outdated Show resolved Hide resolved
cmd/finch-daemon/main.go Outdated Show resolved Hide resolved
@Shubhranshu153 Shubhranshu153 marked this pull request as ready for review October 31, 2024 18:18
swagatbora90
swagatbora90 previously approved these changes Oct 31, 2024
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
@Shubhranshu153 Shubhranshu153 merged commit 55eacb5 into runfinch:main Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants