Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for socket Activation #89

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

Shubhranshu153
Copy link
Contributor

Issue #, if available:

Description of changes:
This enables finch-daemon to be activated by connection to a configured socket also any request to the socket would wait for the daemon to be running preventing any race condition

Testing done:

  1. Configure socket config file
  2. stop finch-service
  3. Send request to finch socket and confirm finch service is started.
  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments

cmd/finch-daemon/main.go Show resolved Hide resolved
cmd/finch-daemon/main.go Outdated Show resolved Hide resolved
docs/finch-daemon-config.md Outdated Show resolved Hide resolved
docs/finch-daemon-config.md Outdated Show resolved Hide resolved
docs/finch-daemon-config.md Outdated Show resolved Hide resolved
@Shubhranshu153 Shubhranshu153 force-pushed the feat-handle-notify branch 3 times, most recently from 3df7f2c to 8bfea07 Compare October 31, 2024 17:20
@Shubhranshu153 Shubhranshu153 marked this pull request as ready for review October 31, 2024 17:20
pendo324
pendo324 previously approved these changes Oct 31, 2024
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor nit

docs/finch-daemon-with-systemd.md Show resolved Hide resolved
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
@Shubhranshu153 Shubhranshu153 merged commit d185ad3 into main Oct 31, 2024
7 checks passed
@Shubhranshu153 Shubhranshu153 deleted the feat-handle-notify branch October 31, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants