Add linter to CI #24
Merged
Add linter to CI #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjun Raja Yogidas <[email protected]>
pendo324
requested changes
Sep 5, 2024
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
improve-ci-lint
branch
from
7331fd6 to
d8b1994
Compare
pendo324
approved these changes
Sep 5, 2024
henry118
reviewed
Sep 5, 2024
| @@ -147,4 +147,4 @@ require ( | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| k8s.io/cri-api v0.29.3 // indirect | |||
| lukechampine.com/blake3 v1.2.1 // indirect | |||
| ) | |||
| ) | |||
There was a problem hiding this comment.
I don't think this is a new line.. line number is still 150
There was a problem hiding this comment.
I mean you're missing the newline character at the end of file. See the red marker here.
There was a problem hiding this comment.
Oh shoot, My bad. Will add this back in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This commit adds golangci linter and yaml lint checks to the CI.
Description of changes:
Testing done:
go mod tidy
local e2e and unit tests
e2e and unit test in my fork
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.