Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add api options to container create #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coderbirju
Copy link
Contributor

@coderbirju coderbirju commented Dec 18, 2024

Issue #, if available:

Description of changes:

Adds the following options to the container create API

  • CpuShares
  • CPUQuota
  • MemorySwappiness64
  • PidsLimit
  • Cgroupns
  • MemoryReservation
  • MemorySwap
  • Ulimit
  • CPUPeriod
  • CapDrop
  • Privileged

Testing done:
Adds e2e tests for all the above options

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coderbirju coderbirju force-pushed the update-container-create-api-1 branch from eb8a215 to 82a5f79 Compare December 18, 2024 06:51
pendo324
pendo324 previously approved these changes Dec 18, 2024
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some minor comments

api/handlers/container/create.go Outdated Show resolved Hide resolved
e2e/tests/container_create.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants