Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e test for com.docker.network.bridge.enable_icc option #104

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

swagatbora90
Copy link
Contributor

Issue #, if available:

Description of changes:
Adds e2e test for enable_icc option
Testing done:
sudo make test-e2e

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@swagatbora90 swagatbora90 changed the title Add e2e test for com.docker.network.bridge.enable_icc option test: add e2e test for com.docker.network.bridge.enable_icc option Nov 26, 2024
@swagatbora90 swagatbora90 force-pushed the enable-icc-e2e branch 3 times, most recently from 46b2a75 to eba63d3 Compare November 26, 2024 19:22
@swagatbora90 swagatbora90 marked this pull request as ready for review November 26, 2024 19:23
pendo324
pendo324 previously approved these changes Nov 26, 2024
e2e/tests/network_create.go Outdated Show resolved Hide resolved
e2e/tests/network_create.go Outdated Show resolved Hide resolved
pendo324
pendo324 previously approved these changes Nov 26, 2024
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the one item.

e2e/tests/network_create.go Outdated Show resolved Hide resolved
@swagatbora90 swagatbora90 merged commit 3d6a531 into runfinch:main Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants