feat: add windows targets in makefile #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
approved these changes
Oct 14, 2023
ginglis13
reviewed
Oct 14, 2023
pendo324
approved these changes
Oct 16, 2023
Signed-off-by: Vishwas Siravara <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
…ream (#175) Issue #, if available: *Description of changes:* Tracks a Lima fork until the SSH quoting issue is resolved upstream. You probably need to run `git submodule set-url src/lima https://github.com/pendo324/lima` and `git submodule update --init --recursive` to get the latest changes *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Issue #, if available: *Description of changes:* - update to latest rootfs built by action - don't extract rootfs, let Lima do it *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Issue #, if available: *Description of changes:* - Since the ssh quote fix is merged, we can track Lima's `master` branch again *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Issue #, if available: *Description of changes:* Failure seen in mac e2e tests on branch `windev`: https://github.com/runfinch/finch/actions/runs/6413564599/job/17412684261?pr=584 update OS image refs. hashes are already correct in windev branch. revert a change to the fedora lima template path. This `lima-template` rule is only used on macOS: https://github.com/runfinch/finch-core/blob/22af4e43c95b2ac591754fc817228b8aff9deddf/Makefile#L79-L93 *Testing done:* On both windows and macOS dev machines: ``` # .gitmodules [submodule "finch-core"] path = deps/finch-core url = https://github.com/ginglis13/finch-core.git branch = makefile-fix ``` ``` make ./_output/bin/finch vm init ``` - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Issue #, if available: *Description of changes:* Add cosign binary to rootfs *Testing done:* - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Vishwas Siravara <[email protected]>
Issue #, if available: *Description of changes:* - Update rootfs archive - Remove arm64 build for rootfs *Testing done:* - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Vishwas Siravara <[email protected]>
Issue #, if available: *Description of changes:* - Adds all dependencies needed to run lima/finch standalone - This includes a lot of DLLs, need a better way to automate this - TODO: after merge, need to modify Finch to set path when calling Lima so that these executables are actually used *Testing done:* - All exes work with an empty `%PATH%` (e.g. `$env:Path = ""; ssh.exe --help` works) - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Issue #, if available: *Description of changes:* - Accidentally removed from previous PR *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Issue #, if available: *Description of changes:* - Remove old version of msys-crypto - Accidentally added because I looked at the DLLs required for an older version of `ssh-keygen.exe`, newer versions don't need this file *Testing done:* - Tested on my windows machine - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Issue #, if available: *Description of changes:* tar option --force-local is used to instruct tar that the input is known to be a local file even if it is interpreted by tar to be a remote file; this appears to have been the case for the wingit local archive as seen in https://github.com/runfinch/finch/actions/runs/6501797014/job/17659749228 https://www.gnu.org/software/tar/manual/html_section/All-Options.html *Testing done:* `make` on windows instance - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Gavin Inglis <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
finch-core changes for windev.
Testing done:
Yes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.