feat: add windows deps #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
vsiravar
approved these changes
Oct 12, 2023
ginglis13
reviewed
Oct 12, 2023
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
1 task
pendo324
added a commit
to runfinch/finch
that referenced
this pull request
Oct 12, 2023
Issue #, if available: *Description of changes:* - Fix env setting for limactl process on Windows *Testing done:* - Tested with new finch-core PR runfinch/finch-core#187 - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 14, 2023
Issue #, if available: *Description of changes:* - Adds all dependencies needed to run lima/finch standalone - This includes a lot of DLLs, need a better way to automate this - TODO: after merge, need to modify Finch to set path when calling Lima so that these executables are actually used *Testing done:* - All exes work with an empty `%PATH%` (e.g. `$env:Path = ""; ssh.exe --help` works) - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available: *Description of changes:* - Adds all dependencies needed to run lima/finch standalone - This includes a lot of DLLs, need a better way to automate this - TODO: after merge, need to modify Finch to set path when calling Lima so that these executables are actually used *Testing done:* - All exes work with an empty `%PATH%` (e.g. `$env:Path = ""; ssh.exe --help` works) - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
vsiravar
pushed a commit
to runfinch/finch
that referenced
this pull request
Oct 17, 2023
Issue #, if available: *Description of changes:* - Fix env setting for limactl process on Windows *Testing done:* - Tested with new finch-core PR runfinch/finch-core#187 - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]>
vsiravar
pushed a commit
to runfinch/finch
that referenced
this pull request
Oct 17, 2023
Issue #, if available: *Description of changes:* - Fix env setting for limactl process on Windows *Testing done:* - Tested with new finch-core PR runfinch/finch-core#187 - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
All exes work with an empty
%PATH%(e.g.$env:Path = ""; ssh.exe --helpworks)I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.