Skip to content

Commit

Permalink
fix: use --force-local in tar (#191)
Browse files Browse the repository at this point in the history
Issue #, if available:

*Description of changes:*

tar option --force-local is used to instruct tar that the input is known
to be a local file even if it is interpreted by tar to be a remote file;
this appears to have been the case for the wingit local archive as seen
in
https://github.com/runfinch/finch/actions/runs/6501797014/job/17659749228

https://www.gnu.org/software/tar/manual/html_section/All-Options.html

*Testing done:*

`make` on windows instance

- [x] I've reviewed the guidance in CONTRIBUTING.md

#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Gavin Inglis <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
  • Loading branch information
ginglis13 authored and vsiravar committed Oct 14, 2023
1 parent 5bd42ba commit 39b06a6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ $(LIMA_OUTDIR)/bin/ssh.exe:
pwsh.exe -NoLogo -NoProfile -c ./verify_hash.ps1 "$(DEPENDENCIES_DOWNLOAD_DIR)\$(WINGIT_x86_BASENAME)" $(WINGIT_x86_HASH)
mkdir -p $(WINGIT_TEMP_DIR)
# this takes a long time because of an almost 4:1 compression ratio and needing to extract many small files
tar -xvjf "$(DEPENDENCIES_DOWNLOAD_DIR)\$(WINGIT_x86_BASENAME)" -C $(WINGIT_TEMP_DIR)
tar --force-local -xvjf "$(DEPENDENCIES_DOWNLOAD_DIR)\$(WINGIT_x86_BASENAME)" -C $(WINGIT_TEMP_DIR)

# Lima runtime dependencies
mkdir -p $(LIMA_OUTDIR)/bin
Expand Down

0 comments on commit 39b06a6

Please sign in to comment.