fix: use compose stop/rm for forceful termination of stubborn containers #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running this test in runfinch/finch-core#472; it looks like compose down is still hanging. Putting this in draft while I investigate further. |
|
There appears to be behavior differences here to account for. Previously compose down would remove the containers pretty forcibly; now it attempts a more graceful shutdown. The challenge is the containers we are using to test are stubborn. i.e. Meaning compose down is sending the signal and hitting the timeout on each teardown. I am going to rework this PR to appropriately handle compose testing teardown. |
austinvazquez
force-pushed
the
extend-timeout-for-compose-down
branch
from
44f192b to
b340dfc
Compare
This change refactors compose logs and compose kill test suites to use compose stop/rm for cleanup. Starting in nerdctl 2.0, compose down attempts to gracefully teardown containers before sending forceful kill signal after a 10 second timeout. For developer experience, this is acceptable, but in automation it does not work well. Compose stop/rm is more preferable for stubborn containers like sleep infinity. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
extend-timeout-for-compose-down
branch
from
b340dfc to
e70dd44
Compare
austinvazquez
changed the title
pendo324
approved these changes
Dec 26, 2024
|
Superseded by #208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#202
Description of changes:
This change refactors compose logs and compose kill test suites to use
compose stop/rm for cleanup. Starting in nerdctl 2.0, compose down
attempts to gracefully teardown containers before sending forceful kill
signal after a 10 second timeout. For developer experience, this is
acceptable, but in automation it does not work well. Compose stop/rm is
more preferable for stubborn containers like sleep infinity.
Testing done:
Ran test in runfinch/finch-core#472
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.